Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Implementing this hook would allow Aurora to ensure that any required Modernizr tests are included when Modernizr is rebuilt.
I'm assuming you'll want media query support. I'm also aware of TypeKit settings in the config. Is there anything else that Aurora has out of the box?
Comments
Comment #1
ruplChanging title to be more specific since I'm about to file lots of these issues :)
Also, I looked through the codebase, is the html5shiv hidden somewhere? Would there be a way to suppress it if Modernizr is enabled, assuming it was included in the Modernizr hook?
Comment #2
iamcarrico CreditAttribution: iamcarrico commentedPostponing this until we can fully review the use of hook_modernizr_info() within the theme layer.
Comment #3
iamcarrico CreditAttribution: iamcarrico commentedMoving this back to active, #1914478: [meta] Provide Modernizr integration for other contrib modules.
We need a list of tests that Aurora should rely on... which might not be any due to its nature of providing very little.
Comment #4
Snugug CreditAttribution: Snugug commentedConsidering there is no test for
box-sizing: border-box
, I'd say we don't have any need for tests in Aurora.Comment #5
ruplActually there is one: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css/b...
I think I'm doing this right? https://github.com/Snugug/Aurora/pull/19
Comment #6
iamcarrico CreditAttribution: iamcarrico commentedFixed in the aurora compass plugin