Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Meta Issue:#1870944: [Meta] Mobile friendly admin pages
Problem/Motivation
Alignment of Add to shortcuts image for pages with long title in NARROW Screens
Admin URL eg:
admin/config/content/formats/filtered_html/disable
admin/config/regional
Proposed resolution
To be determined.
Remaining tasks
To be determined.
Comment | File | Size | Author |
---|---|---|---|
#27 | Screen Shot 2015-09-25 at 11.24.18.png | 122.64 KB | frantisekivanko |
#16 | after-applying-patch-short-title.png | 16.1 KB | Manjit.Singh |
#16 | after-applying-patch-long-title.png | 13.52 KB | Manjit.Singh |
#16 | before-applying-patch-short-title.png | 16.41 KB | Manjit.Singh |
#16 | before-applying-patch-long-title.png | 13.99 KB | Manjit.Singh |
Comments
Comment #1
LewisNymanComment #2
hansrossel CreditAttribution: hansrossel commentedFixed the non overlay and overlay version of the shortcuts and some general padding for the header title and cleanup.
Links to test
with overlay: #overlay=admin/config/content/formats/full_html/disable
without overlay: /admin/config/content/formats/full_html/disable
Comment #3
hansrossel CreditAttribution: hansrossel commentedsecond try
Comment #4
hansrossel CreditAttribution: hansrossel commentedSome screenshots after
Comment #5
OostieWorks great when you want to add a shortcut but not when you want to delete one (with overlay).
Comment #6
OostieComment #7
Shyamala CreditAttribution: Shyamala commentedadding back novice tags
Comment #8
LewisNymanHey guys, I was just playing around in Firebug and I found what I hope is a simpler solution to the issue:
Comment #9
LewisNymanComment #10
bleen CreditAttribution: bleen commentedWhen I looked at this in chrome on OSX the shortcut link was jumpin all over the place:
http://screencast.com/t/k2jftPI3QU
Comment #11
LewisNymanAh, it appears I complete forgot about the hover effect.... we should be removing this effect on touch devices for a start, maybe we can combine two solutions to cover touch and non-touch.
I am concerned about the amount of 'mobile' testing going on without actually looking at any mobile devices... we do have a 10 user subscription to Browser Stack somewhere...
Comment #12
LewisNymanOk, so what I've done here is kept the behaviour of the patch in #8 for touch devices but removed the hover effect.
For non-touch devices on a narrow viewport I've taken the approach of #3.
This is my justification:
I've attached screenshots of narrow viewports on touch and non-touch devices.
Comment #14
rteijeiro CreditAttribution: rteijeiro commentedTried to re-roll the patch but not sure if everything is there.
Comment #15
saki007sterI reviewed this patch , it seems to be working fine. I am attaching screenshots for the reference.
Comment #15.0
saki007sterAdded admin/config/regional
Comment #16
Manjit.SinghI have used the tool Ripple (Chrome extension). Please find the attached screenshots which are showing before and after applying the patch.
Comment #17
Manjit.SinghChanged to RTBC
Comment #18
Xano14: 1876208-14.patch queued for re-testing.
Comment #19
webchickHm. I guess I'm having a hard time figuring out why this is preferable.
Without the patch, on a touch device (iOS simulator), when I click on the + sign I get an expanded "Add to default shortcuts" so I can tell what that button does.
With the patch, this doesn't happen.
The OP as well as the issue title seems to imply this is just an alignment fix, which makes sense to me. I'm not sure why we are also including a behaviour change.
I'm wondering though if we want to postpone this on #2022695: Content header style update? That seems like it would render this CSS moot.
Comment #20
LewisNymanYes that's a good idea.
Comment #21
mgiffordSo that leads to #1953374: Implement Seven style guide for core overlay which is won't fix... Should this be marked as Won't fix then or is there another way around this?
Comment #22
LewisNymanI think this is still a problem
Comment #23
Manjit.SinghComment #24
LewisNymanThis problem is Seven theme specific
Comment #25
yoroy CreditAttribution: yoroy at Wunder commentedNot sure what needs to be done here. Asking because it's the last open issue in the major issue #1870944: [Meta] Mobile friendly admin pages
Comment #26
valthebaldevaluating during Friday sprint
Comment #27
frantisekivanko CreditAttribution: frantisekivanko commentedIssue is no more relevant.
See screenshot.
Comment #28
frantisekivanko CreditAttribution: frantisekivanko commented