URLs not inserted with relative paths [#1931114]

Insert module has inserted my uploaded image with two bugs:

<a href="http://www.example.com/files/foo.png"  class="colorbox colorbox-insert-image" rel="gallery-all"><img typeof="foaf:Image" src="http://www.example.com/files/styles/large/public/foo.png?itok=72jZh0Id" alt=""  class="image-large" /></a>

Bug 1: All links are still absolute, but the Use absolute paths checkbox is disabled for sure in the content type field settings. Default insert type is Colorbox large.
Bug 2: There is a ?itok=72jZh0Id attached where I have no clue what this is made for, but it's static and this cannot correct in all cases.
Bug 3: Several double spaces without a need.

Comment	File	Size	Author
#7	colorbox_insert_absolute_1931114_7.patch	5.08 KB	frjo
#7

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

quicksketch

he/him

CreditAttribution: quicksketch commented 2 March 2013 at 22:31

Project:	Insert	» Colorbox
Version:	7.x-1.3	» 7.x-1.5
Priority:	Major	» Normal

Looks like you are using Colorbox, which provides its own insert templates, it is probably responsible for bug #1 and #3.

Bug #2 isn't a bug at all, it's a new requirement introduced in Drupal 7.20. See the release notes: http://drupal.org/drupal-7.20-release-notes

Comment #2

frjo CreditAttribution: frjo commented 3 March 2013 at 11:56

Look like I need to update the Insert template in Colorbox with the new features that has been added to the Insert module lately.

Will try to make time for that in the coming week.

Comment #3

hass CreditAttribution: hass commented 10 March 2013 at 12:21

Version:

7.x-1.5

» 7.x-2.3

Comment #4

quicksketch

he/him

CreditAttribution: quicksketch commented 21 March 2013 at 21:30

Title:

Insert relative is broken

» Insert integration needs to include "itok" query string for Drupal 7.20 and later

Updating title for descriptiveness.

Comment #5

hass CreditAttribution: hass commented 24 March 2013 at 09:55

The more important here is that the paths are not relative to the webroot and causing several troubles like warnings in SSL sections.

Comment #6

hass CreditAttribution: hass commented 24 March 2013 at 10:16

Title:	Insert integration needs to include "itok" query string for Drupal 7.20 and later	» URLs not inserted with relative paths
Version:	7.x-2.3	» 7.x-2.x-dev
Priority:	Normal	» Major

Comment #7

frjo CreditAttribution: frjo commented 24 September 2013 at 14:33

Status:

Active

» Needs review

File	Size
colorbox_insert_absolute_1931114_7.patch	5.08 KB

Please test this patch. I have attempted to copy over all the new functionality from version 7.x-1.3 of the Insert module.

Comment #8

Remyf CreditAttribution: Remyf commented 13 October 2013 at 14:06

It seems the img tag (thumbnail) now has a relative source, but the a href tag still has an absolute path to the colorbox image.

Comment #8.0

Remyf CreditAttribution: Remyf commented 13 October 2013 at 14:06

Issue summary:

View changes

Updated issue summary.

Comment #9

frjo CreditAttribution: frjo commented 30 November 2013 at 12:09

Issue summary:	View changes
Status:	Needs review	» Fixed

Comment #10

JBecker CreditAttribution: JBecker commented 3 December 2013 at 11:26

I can confirm #8. $url is a relative path in Version 7.x-2.5 but $path still is an absolute path to the image.

Comment #11

14 December 2013 at 12:10

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #12

uno CreditAttribution: uno commented 26 May 2014 at 16:15

Status:

Closed (fixed)

» Active

As far as I can see this is not fixed, still there in 7.x-2.x-dev ( 2014-May-07) and in 7.x-2.5, so marking as active.

Comment #13

workplaysleep CreditAttribution: workplaysleep commented 26 November 2014 at 07:57

Same problem with 7.x-2.8 for me it worked to do add the following code to colorbox-insert-image.tpl.php
Not the most elegant solution but simple and effective.

$p = parse_url($path);
if (isset($p['path']) ) {
$path = $p['path'];
}
print $path; "....

Comment #14

frjo CreditAttribution: frjo commented 10 October 2016 at 11:57

Status:

Active

» Closed (works as designed)

Comment #15

Olafski

Hamburg

CreditAttribution: Olafski at buerobackbord commented 9 February 2018 at 10:01

@frjo The absolute links seem to be still there, leading to different problems, see also the newer issue https://www.drupal.org/project/colorbox/issues/2644266. Why do you think they "work as designed"?