Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When you have a view the contextual links don't work anymore.
The hover itself still does work, though the contextual js kicks in too fast.
Comment | File | Size | Author |
---|---|---|---|
#21 | vdc-1933426-21.patch | 529 bytes | dawehner |
#17 | drupal-1933426-17.patch | 526 bytes | dawehner |
#1 | drupal-1933426-1.patch | 1.09 KB | dawehner |
Comments
Comment #1
dawehnerLet's move the contextual links js to hook_library_info and fix the order.
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedwithout the patch contextual links wouldnt fire..now works as should.
also +1 to have them as library
Comment #4
dawehner#1: drupal-1933426-1.patch queued for re-testing.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commented#1: drupal-1933426-1.patch queued for re-testing.
Comment #7
ParisLiakos CreditAttribution: ParisLiakos commentednow that bot agrees
Comment #8
webchickYay!
Committed and pushed to 8.x. Thanks!
Comment #9
damiankloip CreditAttribution: damiankloip commentedDo you think we should look at moving this into views_ui module instead? Seems it might be better living in there, as that's when we are using them.
Comment #10
dawehnerNot sure, as this adds support for all kind of contextual links, not just edit view, at least in theory.
Comment #11
damiankloip CreditAttribution: damiankloip commentedHmm, true. I remember now. I guess you could use them to add filters etc.. I think we could still move all of this into the UI though?
Let's fix this again (sorry) and create a followup?
Comment #12
dawehnerYeah, so views_ui is one of these modules that want to add new contextual links to it.
Comment #13
damiankloip CreditAttribution: damiankloip commented#1933766: Move all contextual links code to views_ui module
Comment #14
Wim LeersIf a custom weight is necessary, then it should be documented *why*. Otherwise, we end up with unintelligible loading order/dependencies.
Comment #16
Wim Leers(Sorry for reopening this issue.)
This patch moved the .js file into a library. Yay!
But, it failed to move the weight comment along with it. Look at the patch in #1: the weight comment at the top makes no sense anymore, it should be moved into the library definition.
Comment #17
dawehnerWell, the problem is a bit tricky here.
Even this actually "depends on contextual.js" this file has to be loaded before, as it alters some css classes in order to work properly,
so what about documenting this.
Comment #18
xjmPlease open new issues for followups in the future. :) I had to read this whole issue to figure out it had nothing to do with what I was trying to find an issue for.
Comment #19
dawehner#17: drupal-1933426-17.patch queued for re-testing.
Comment #21
dawehnerjust a reroll.
Comment #22
damiankloip CreditAttribution: damiankloip commentedLooks fine.
Comment #23
webchickThat works, but doesn't solve the problem pointed out in #16, which is that we need to remove the comment from above the line that is now just drupal_add_library(...) without any specialness about weights.
So I went ahead and did that as well and then committed/pushed #21 to 8.x. Thanks!