They haven't been run in a long time, but they've been broken.

First offending commit: #1408496: Avoid numeric keys as much as possible in exports; use drupal_map_assoc or such (user_permission roles array)

I'll post a patch in a bit.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

#1935876: Drush features-export doesn't create feature is another one. I don't believe you can test drush like that at all.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
6.46 KB

#1530386: Avoid unnecessary cache rebuilds and improve installation performance was the final offending commit.
This should be committed, and each of those issues reopened to fix properly. Issue queue tests won't run until the branch passes.

It removes the bogus test coverage of the drush issue, and straight up reverts the other two.

mpotter’s picture

Hmm, rather than reverting previous issue patches that actually solved known problems, can we take a look at the actual tests themselves? Perhaps they need to be tweaked instead?

mpotter’s picture

FileSize
651 bytes

Here is a quick patch for the broken user permission tests to use the role name instead of a numeric value.

mpotter’s picture

FileSize
1.55 KB

Here is a new patch that combines the fix to user permissions with a change to how the test for ctools works.

Basically, it first checks for the lack of ctools hooks. Then it enables the modules, then it actually enables the features_test module. Only when an actual feature module is enabled should the actual ctools hooks be created.

mpotter’s picture

FileSize
3.13 KB

Here is the completed patch, with the array($try) from #5 fixed, and the drush test removed.

Status: Needs review » Needs work

The last submitted patch, features-1954596-6.patch, failed testing.

tim.plunkett’s picture

mpotter’s picture

Nice! Thanks for the help with this Tim!

pfrenssen’s picture

Wow great work, nice to see this :D

I had opened a similar issue, will close it now -> #1804262: Chaos Tools test fails with latest versions of core + contrib

I wonder though why you removed the Drush test? I reviewed this issue and the test worked perfectly.

tim.plunkett’s picture

@pfrenssen, the testbot couldn't run it, and it didn't pass for me locally. Now that tests are running on the issue queue, then having the testbot be able to run it is important :)

pfrenssen’s picture

Sure! Test bots are really important :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.