Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
They haven't been run in a long time, but they've been broken.
First offending commit: #1408496: Avoid numeric keys as much as possible in exports; use drupal_map_assoc or such (user_permission roles array)
I'll post a patch in a bit.
Comment | File | Size | Author |
---|---|---|---|
#6 | features-1954596-6.patch | 3.13 KB | mpotter |
#5 | features-1954596-5.patch | 1.55 KB | mpotter |
#4 | features-1954596-4.patch | 651 bytes | mpotter |
#2 | features-1954596-2.patch | 6.46 KB | tim.plunkett |
Comments
Comment #1
tim.plunkett#1935876: Drush features-export doesn't create feature is another one. I don't believe you can test drush like that at all.
Comment #2
tim.plunkett#1530386: Avoid unnecessary cache rebuilds and improve installation performance was the final offending commit.
This should be committed, and each of those issues reopened to fix properly. Issue queue tests won't run until the branch passes.
It removes the bogus test coverage of the drush issue, and straight up reverts the other two.
Comment #3
mpotter CreditAttribution: mpotter commentedHmm, rather than reverting previous issue patches that actually solved known problems, can we take a look at the actual tests themselves? Perhaps they need to be tweaked instead?
Comment #4
mpotter CreditAttribution: mpotter commentedHere is a quick patch for the broken user permission tests to use the role name instead of a numeric value.
Comment #5
mpotter CreditAttribution: mpotter commentedHere is a new patch that combines the fix to user permissions with a change to how the test for ctools works.
Basically, it first checks for the lack of ctools hooks. Then it enables the modules, then it actually enables the features_test module. Only when an actual feature module is enabled should the actual ctools hooks be created.
Comment #6
mpotter CreditAttribution: mpotter commentedHere is the completed patch, with the array($try) from #5 fixed, and the drush test removed.
Comment #8
tim.plunkettCommitted http://drupalcode.org/project/features.git/commit/f712a90, its passing again: http://qa.drupal.org/pifr/test/458073
Comment #9
mpotter CreditAttribution: mpotter commentedNice! Thanks for the help with this Tim!
Comment #10
pfrenssenWow great work, nice to see this :D
I had opened a similar issue, will close it now -> #1804262: Chaos Tools test fails with latest versions of core + contrib
I wonder though why you removed the Drush test? I reviewed this issue and the test worked perfectly.
Comment #11
tim.plunkett@pfrenssen, the testbot couldn't run it, and it didn't pass for me locally. Now that tests are running on the issue queue, then having the testbot be able to run it is important :)
Comment #12
pfrenssenSure! Test bots are really important :)