Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Right now, og_memberships can be fielded and the fields can be entered when users request membership in a group, but not modified thereafter due to the lack of an edit form. It would be awesome if there were an edit form available for og_membership entities as well as the ability to integrate that edit form and its components with Panels so that custom "edit this attribute of your membership in this/these OG(s)" forms could be easily constructed through the UI.
Comment | File | Size | Author |
---|---|---|---|
#5 | 1909130-5.patch | 9.53 KB | Jody Lynn |
#3 | 1909130-3.patch | 9.28 KB | Jody Lynn |
#1 | og-1909130-1.patch | 11.18 KB | Jody Lynn |
Comments
Comment #1
Jody LynnThis patch adds edit links to the Members Admin view and the edit forms. It includes the ability to change member roles on the edit form (see also [#1920632))
The code should be refactored to be merged/less redundant with the add membership form.
Kazanir, the other request about the Panels integration should be a separate follow-up request.
Comment #2
amitaibu@Jody Lynn, you are awesome! :)
Capital letter here and other comments.
Maybe add a comment, that we want only the non-default roles.
Why do we need it as autocomplete. I would assume it should be #markup
if ($og_roles)
is probably enough.This will cause OG-membership's bundle to change. Not sure how Drupal deals with that (in terms of cleaning up fileds that don't exist in the different bundle).
Extra space "in group"
We'll probably won't need this on edit memberships. See above comment about the auto-complete.
Comment #3
Jody LynnI removed the ability to edit the account of the membership as well as to change its bundle.
Also addressed other review items above.
Comment #4
amitaibuWhen I try to edit the "Request Message" of any group-member it doesn't change the value -- does it work for you?
Also, I think it would be nicer is we would be redirected back to the "People" tab after editing the membership.
Comment #5
Jody LynnI added the destination setting to the view.
I brought back the field editing functionality by putting back $og_,membership->save(). Failed to test last time.
Comment #6
amitaibuAwesome! committed, thanks.