Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I don't know how the EntityNG conversions factor in to all of this, but as far as ConfigEntity goes, all of the "entity keys" (id/label/bundle/uuid) are public properties. They shouldn't be. We should work toward making them all protected.
This is just a first attempt. To see what happens.
Comment | File | Size | Author |
---|---|---|---|
protected-properties-ftw.patch | 16.97 KB | tim.plunkett | |
Comments
Comment #2
xjmComment #3
andypostSuppose better to split this into set of issues to fix each module separate
Comment #4
BerdirThis doesn't go in the same direction as EntityNG. EntityNG does, in fact, *remove* them completely, they are currently on there for autocomplete support but if we move to interfaces, there's not much point in keeping that either.
Comment #5
xjmOh. I don't think we should make everything protected. Just stuff that should never change, like metadata and the unique identifiers.
Comment #6
BerdirEntityNG does not make that difference. Everything that is a field of an entity (this includes id's, everything is a field) is access as a property but through magic getters.
Comment #7
tim.plunkett#2016679: Expand Entity Type interfaces to provide methods, protect the properties is handling this.