Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#11 | update-fetch-guzzle-1862538-11.patch | 1.21 KB | Berdir |
#9 | update-fetch-guzzle-1862538-9.patch | 1.21 KB | Berdir |
#3 | update-guzzle-1862538-3.patch | 1.41 KB | Berdir |
#1 | update-guzzle-1862538-1.patch | 2.36 KB | Berdir |
Comments
Comment #1
BerdirAnother easy conversion, haven't run the tests yet.
Comment #3
BerdirThis should pass the tests and is more like the original code.
Comment #4
rbayliss CreditAttribution: rbayliss commentedLooks good to me.
Comment #5
YesCT CreditAttribution: YesCT commented#3: update-guzzle-1862538-3.patch queued for re-testing.
Comment #6
Sutharsan CreditAttribution: Sutharsan commentedI've got nothing to add. It's RTBC to me.
Comment #7
BerdirNeeds to be re-rolled to use the exception handling pattern from the standardize issue. Which should probably wait until that is commited.
Otherwise, this will result in an uncatched exception bubbling up all the way if e.g. the network or d.o is down.
Comment #8
YesCT CreditAttribution: YesCT commentedhere is the standardize issue @Berdir suggests going in first: #1875792: Standardize Guzzle exception handling
Comment #9
BerdirRe-roll. Looks better now :)
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commentedjust one thing
should be in a newline after closing }
Comment #11
BerdirThere you go. Was too lazy for an interdiff ;)
Comment #12
ParisLiakos CreditAttribution: ParisLiakos commentedready to fly, thanks:)
Comment #13
twistor CreditAttribution: twistor commentedAnd what about BadResponseException?
Comment #14
BerdirThat's a subclass of RequestException. We only need to differentiate if we want to log different errors otherwise re-act differently on them. I think the default getMessage() of either exception is fine for this.
Comment #15
twistor CreditAttribution: twistor commentedAhh, right.
Comment #16
alexpottCommitted 28f278b and pushed to 8.x. Thanks!