Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#865536-204: drupal_add_js() is missing the 'browsers' option is being handled in #1952522: Bundler doesn't respect JS browser conditionals (via core patch). but there are other D7 patches that are useful.
drupal_add_js D7 issues
drupal_add_css D7 issues
Comment | File | Size | Author |
---|---|---|---|
#2 | advagg-1956142-2-add-async-onload-fix-defer.patch | 3.78 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedCSS candidates
#1021622-22: Improper escaping of CDATA for inline css
#1034208-4: drupal_sort_css_js() ignores media and browser keys
JS candidates
#1140356-61: Add async, onload property to script tags
#1664602-44: Allow attributes to be passed to drupal_add_[css|js] (SRI)
#1279226-15: jQuery and Drupal JavaScript libraries and settings are output even when no JS is added to the page
#812388: 'scope' parameter does not work in drupal_add_js
#1554122: drupal_group_js doesn't check if $javascript is empty
#1710002-8: Weight is not set for Drupal.settings JavaScript
#1949778: drupal_build_js_cache() is attempting to aggregate external protocol-relatice JavaScript
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedOut of all the patches the only ones that can easily be done is a merge of #1140356: Add async, onload property to script tags & #1664602: Allow attributes to be passed to drupal_add_[css|js] (SRI). This patch has been committed.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedComment #4
memoday CreditAttribution: memoday commentedHi Mike,
Is it OK to start using your D7 version on product site? Any recommendation/advice please?
Comment #5
mikeytown2 CreditAttribution: mikeytown2 commentedIf you've tested it out locally and it works, it should be OK to use.
Just be aware of #1946218: test with other modules & themes. I especially need to make sure advagg works with the CDN and CSS Embedded Images modules. I'm pretty sure I have advagg working with jQuery Update. And some nice to have integration would be JS script loaders like LABjs, HeadJS, and Script.js.
I plan on releasing an alpha once CDN and CSS Embedded Images is working 100%. Until a 7.x-2.x alpha version is released there is no upgrade path (from dev to dev).
In terms of AdvAgg, it hasn't been thoroughly performance tested so it could be doing redundant stuff on the PHP side of things. Also the advagg_mod submodule has some experimental stuff in in, so I would be careful with what you do when using it.