We need to create fields only for nodes with enabled commenting or having hidden comments

CommentFileSizeAuthor
#1 upgrade-path.patch14.57 KBandypost
upgrade.patch.txt13.44 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
upgrade-path.patch14.57 KB

Current state

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

It needs profiling and optimizations

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Tested #1907960-123: Helper issue for "Comment field" fails in #1907960-130: Helper issue for "Comment field"

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review

I think we can won't fix this now. Its too late to be considering upgrade path changes imo.
If we create an extra comment field during upgrade for a node type that doesn't have comments enabled, the site admin can just delete it. No harm done.
Thoughts?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Suppose some code could be merged to main issue. Also it's ok to wont fix

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Closed (won't fix)

Agreed, this is wontfix. Thanks!