Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Guessing it was supposed to be:
if ((empty($form[$child]['#type']) || !em...
Instead of:
if ((!empty($form[$child]['#type']) || !em...
The way the conditional was it would always eval true if the #type was set before even looking whether it was a fieldset or button.
Comment | File | Size | Author |
---|---|---|---|
#4 | panopoly_magic-1961726-4.patch | 825 bytes | tim.plunkett |
panopoly_magic-index-not-found-341.patch | 1.03 KB | squidhaven |
Comments
Comment #1
populist CreditAttribution: populist commentedMoving to main queue for review
Comment #2
populist CreditAttribution: populist commentedThanks so much for reporting/fixing! This has been reviewed and pushed to -dev.
Comment #3
tim.plunkettThis now throws notices and causes the form_id et al to never be copied over, so the code later on (http://drupalcode.org/project/panopoly_magic.git/blob/refs/heads/7.x-1.x...) completely overwrites the form ID.
Also, I don't understand the OP.
As it was before:
The conditional the OP describes assumes that
(!empty($form[$child]['#type']) || !empty($form[$child]['#tree']))
is not wrapped as a sub condition.With this committed, you get notices thrown for all #markup elements.
So, please revert this commit.
Comment #4
tim.plunkettAlso, the reason I made this major: I can no longer add Field API fields to a panelized node. The first configure screen just hangs, since it overwrites the form_id with NULL because of this change.
Uploading a patch for drush make purposes, but
git revert ca28725
would work just as well.Comment #5
populist CreditAttribution: populist commentedThanks for the update tim.plunkett. This update is also reviewed/committed. Sorry for the confusion.
Comment #6
populist CreditAttribution: populist commentedThanks for the update tim.plunkett. This update is also reviewed/committed. Sorry for the confusion.