Follow on from #1939024: Convert action_admin_manage to a new-style Controller and blocked until that issue is committed in some form (because commits would otherwise conflict - issues are dependent). Probably also makes sense to include action_admin_delete_form in this conversion.

Convert this page callback to a new-style Controller, using the instructions on http://drupal.org/node/1800686

CommentFileSizeAuthor
#3 1944756-action-admin-configure-controller-3.patch9.73 KBkim.pepper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ayelet_Cr’s picture

ayelet_Cr CreditAttribution: ayelet_Cr commented
Assigned: Unassigned » ayelet_Cr
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented

@ayelet_Cr are you still working on this issue?

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Assigned: ayelet_Cr » kim.pepper
Status: Active » Needs review
FileSize
1944756-action-admin-configure-controller-3.patch9.73 KB

Haven't had any activity on this for a week, so I've re-assigned to myself.

First attempt attached.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

The moved code here is ugly as sin. But fixing that is not within scope.

The conversion is correct otherwise.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Add another function for conversion which would make little sense as a separate issue.