API page: http://api.drupal.org/api/drupal/core%21modules%21user%21user.module/fun...
Enter a descriptive title (above) relating to function user_login_finalize, then describe the problem you have found:
> calls hook_user op 'login'
That doesn't exist any more! It's hook_user_login() now.
Comment | File | Size | Author |
---|---|---|---|
#10 | fix-documentation-1966948-10.patch | 624 bytes | apaderno |
#5 | fix-documentation-1966948-5.patch | 623 bytes | apaderno |
#3 | fix-documentation-1966948-3.patch | 621 bytes | apaderno |
Comments
Comment #1
jhodgdonOMG that is a really OLD reference (wrong in D7 as well). Thanks for the issue -- should be a good Novice project to fix... oh good you already tagged it. :)
Comment #3
apadernoComment #4
joachim CreditAttribution: joachim commentedAFAIK the name of the hook should get a () at the end so it's parsed into a link.
(Are you a novice? :p I'm sure I remember you from Drupalcon Copenhagen! :)
Comment #5
apadernoI used the same style used for the hook name in that Drupal 6 page. This is that patch that uses
hook_user_login()
for the hook name.(I am a newbie; I started learning Drupal 3 months ago, and I am now trying to help with some Drupal patches.
;-)
)Comment #6
apaderno(I told you I am a newbie.
;-)
)Comment #7
jhodgdonThere's no restriction that says "Only pure novices can patch issues tagged Novice". :)
Anyway, one more minor thing: in Drupal land we use the dreaded Oxford serial comma (so we need a comma before "and"). Other than that, looks fine to me, thanks!
Comment #8
joachim CreditAttribution: joachim commentedI was only kidding :)
And yay for the Oxford comma!
Comment #9
jhodgdonOh good that you were kidding -- in issue queue communication, sometimes it's hard to get tone of voice, body language, etc. from pure text. I wasn't quite sure and I would hate for anyone to think they weren't welcome to make any patch they'd like to make!!! :)
Comment #10
apadernoGee, I am surely less than a novice, with 3 tried patches.
:-)
Comment #11
jhodgdonThanks! That patch looks good and I'll get it committed shortly.
Comment #12
jhodgdonThanks again! Committed to 8.x and 7.x.