Hello,
I use yours module views_slideshow and I thank you for yours works.
I use jQuery Cycle plugin, and I set that there's 3 element on one slide
I've a problem when I enable Hide controls if there is only one slide, the controls disappear everytime.
I've crete a patch to resolve this problem. I hope that it's usefull

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

swirt’s picture

I have the same issue. I have the slideshow set to show 3 images on a slide, and in my test case there are 9 images total. If I set the option to hide the controls if there is only one slide, the controls are not output to the html, ever.

I believe the behavior in my case should be that there are controls output if there are more than 3 images in the collection (since the slide displays three at a time) and here should be no controls if there are 3 or fewer images.

swirt’s picture

Update: I used the patch above and it all works as it should now. Thanks ts145nera.

This really should be added to the module.

Pomliane’s picture

Status: Active » Needs review
MustangGB’s picture

Version: 7.x-3.x-dev » 7.x-3.0
Priority: Major » Normal
Status: Reviewed & tested by the community » Needs review
barraponto’s picture

jonhattan’s picture

Version: 7.x-3.0 » 7.x-3.x-dev
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Patch in #5 RTBC.

DuaelFr’s picture

This patch needs to be rerolled (new patch following)

DuaelFr’s picture

Rerolled on the last dev version.
Please commit :)

wangqizhong’s picture

Version: 7.x-3.0 » 7.x-3.x-dev
Priority: Normal » Major
Status: Needs review » Fixed

Thanks a lot to barraponto, DuaelFr, mogtofu33, ts145nera and everyone else for the great work on the patches, testing, reviews and reporting.

It's more time this got committed and I went ahead and had this rolled at:

7.x-3.x: 54b815f

Marking this as fixed.

Please let me know if you would have any other questions, comments, issues or concerns on any of these changes, I would be glad to provide more information.
Thanks again to everyone for the help and great work on this issue.

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.