Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
The inline documentation is miss leading. see attached patch.
Comment | File | Size | Author |
---|---|---|---|
#8 | 1906484-8-field-ui-field-settings-form.patch | 539 bytes | dcam |
field_ui_field_setting_form_submit_correction.patch | 577 bytes | smiletrl | |
Comments
Comment #1
smiletrl CreditAttribution: smiletrl commentedComment #3
aspilicious CreditAttribution: aspilicious commentedfield_ui_field_setting_form_submit_correction.patch queued for re-testing.
Comment #5
jhodgdonThanks for the patch! The test failures do not appear to be related to the patch. I'll wait to commit until we can get it to turn green though...
Comment #6
jhodgdonfield_ui_field_setting_form_submit_correction.patch queued for re-testing.
Comment #7
jhodgdonThanks again -- committed to 8.x.
I think we need to do the same patch in 7.x, but the patch here doesn't apply, so it needs to be ported.
Comment #8
dcam CreditAttribution: dcam commentedBackported the patch in the OP to D7.
Comment #9
jhodgdonThis patch is fine... thanks!
I also noticed when I went to api.drupal.org and looked up this function that it says
@ingroups forms
and it should be
@ingroup forms
[no s on @ingroup]
Could we go back to d8 and fix that, then fix both problems in d7, or should we start another issue? I just checked with grep and this is the only place in core that has this typo.
Comment #10
jhodgdonI decided to commit the patch in #8 since I was doing some other 7.x commits anyway. Thanks!
Filed this follow-up issue for the @ingroups thing:
#1961832: Docs typo in field_ui.admin.inc