The service container is used before it's set in the drupal error handler [#1974570]

watchdog() is used by the custom error handler that is set by Drupal. Watchdog() gets the ip address by calling Drupal::request()->getClientIP(), which requires that the service container is set. This makes all errors really serious, since the container is not set yet.

This could possibly also affect other parts of the system which are called early.

Comment	File	Size	Author
#3	drupal-move-error-handler-1974570-3.patch	1.41 KB	fabsor
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fabsor CreditAttribution: fabsor commented 19 April 2013 at 08:59

There are two ways I can think of to solve this issue:

1. Set the service container in the BOOTSTRAP_CONFIGURATION phase.
2. Modify watchdog and other possible places to check if the container is set where appropriate.

It seems to me that the first choice makes the most sense.

Comment #2

fabsor CreditAttribution: fabsor commented 19 April 2013 at 09:00

Title:

watchdog() can be called before the service container is set

» The service container is used before it's set in the drupal error handler

Comment #3

fabsor CreditAttribution: fabsor commented 19 April 2013 at 09:14

Status:

Active

» Needs review

File	Size
drupal-move-error-handler-1974570-3.patch	1.41 KB

The minimal effort is to move the error handler code to the boot phase, after initializing the service container. This not ideal, since we probably want to use our error handler as early in the process as possible, but it would be hard to refactor it to work, but I'm setting this to needs review anyway to get some eyes on it =)

watchdog() uses the service container for getting the ip_address(), but it also calls hook_watchdog through module_implements, which requires the service container as well.