Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Please add support for new Twitter Cards types https://dev.twitter.com/blog/mobile-app-deep-linking-and-new-cards :
- Gallery Card https://dev.twitter.com/docs/cards/types/gallery-card
- App Card https://dev.twitter.com/docs/cards/types/app-card
- Product Card https://dev.twitter.com/docs/cards/types/product-card
And new twitter:domain
tag.
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 3.59 KB | Albert Volkman |
#14 | twitter_cards-1963678-14.patch | 7.6 KB | Albert Volkman |
#13 | twitter_cards-1963678-8.patch | 7.65 KB | gnuget |
#12 | interdiff.txt | 2.43 KB | gnuget |
#12 | summary_large_image_and_gallery_cards_additions-1963678-7.patch | 2.28 KB | gnuget |
Comments
Comment #1
DamienMcKennaComment #2
archimedes CreditAttribution: archimedes commentedSeconded.
One question/suggestion:
My suggestion is to make the field for the type of card into a regular open field entry. I wasn't clear on why that field is a dropdown select box. It didn't look like my selection in that box affected any of the other fields, but it adds the extra overhead of requiring a module update whenever Twitter adds a new card design (even ones that use existing other tags/fields). Am I missing something?
Comment #3
troybthompson CreditAttribution: troybthompson commentedsummary_large_image as well. I don't see the need for the select either, unless it changes which tags get outputted or something.
Comment #4
Chris Charlton+1 for 'summary_large_image' type.
Comment #5
Chris CharltonFYI, Twitter controls 'twitter:domain':
This is mentioned in the Twitter Card Validator tool.
Comment #6
DC_Marc CreditAttribution: DC_Marc commentedLet me know if this patch works. I had a business case for adding summary_large_image and gallery, so that's all this does. I tested my site using the Twitter validator, and it seems to work.
Comment #8
DC_Marc CreditAttribution: DC_Marc commentedThis patch wasn't tested on the latest code base, which is why it failed the automated test, but it should work against 7.x-1.0-beta7. Anyone have that installed and can verify? I wanted to test on a clean working stable version.
Marc
Comment #9
JordanMagnuson CreditAttribution: JordanMagnuson commentedWorking for me on production site. Would love to see this committed.
Comment #10
gnugetThis patch doesn't add support for:
- app-card
- product-card
Only for:
- Gallery card
- summary_large_image
And needs to be re-rolled for the development version.
Comment #11
gnugetComment #12
gnugetWell after to look in the patch the problem was the file wasn't made in the metatag module but in the Drupal root directory.
This new version should be pass the tests.
I will be working on this.
Comment #13
gnugetHere another patch which include the "App" card and the "Product" card.
Comment #14
Albert Volkman CreditAttribution: Albert Volkman commentedThis patch re-rolls the previous patch, and fixes the "Iphone" and "Ipad" typos.
Comment #15
DamienMcKennaCommitted. Thank you for the help!
Comment #16
Albert Volkman CreditAttribution: Albert Volkman commented