Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Status: Active » Needs review
FileSize
6.1 KB
ParisLiakos’s picture

Looks pretty good. Some nitpicks:

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+  /**
+   * Injects Request and Entity Manager Service.
+   *
+   * @param \Symfony\Component\DependencyInjection\ContainerInterface $container
+   *   The DI container.
+   */

{@inheritdoc}

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+   * Page callback: Displays add custom block links for available types.

No Page Callback:

+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Controller/CustomBlockController.phpundefined
@@ -0,0 +1,101 @@
+   * @see custom_block_menu()

this should be removed

larowlan’s picture

larowlan’s picture

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

looks awesome, thanks! it will be perfect once the issue above is in :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7449317 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.