Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta #500866: [META] remove t() from assert message
Comment | File | Size | Author |
---|---|---|---|
#13 | 1797272-13-t-filter.patch | 74 KB | dcam |
#8 | 1797272-8-t-filter.patch | 74.03 KB | dcam |
#3 | 1797272-3-t-filter.patch | 76.83 KB | Lars Toomre |
#1 | filter-1797272-1.patch | 65 KB | xjm |
Comments
Comment #1
xjmBigger. No
format_string()
.Comment #2
xjmComment #3
Lars Toomre CreditAttribution: Lars Toomre commentedThis patch takes the patch from #1 and adds coveragefor missing coverage. This now has 212 changes across 8 Test files. According to my local install, there are no other t() changes needed for this module.
Let's see what the bot thinks of all of these cumulative changes.
Comment #4
dcam CreditAttribution: dcam commentedI tested #3. I didn't find any more t()'s around Filter module test assert messages. The patch looks ok to me.
Comment #5
Lars Toomre CreditAttribution: Lars Toomre commentedThanks for the review @dcam!
Comment #6
webchickTum te tum...
Comment #7
jhodgdonThanks! 212 changes committed to 8.x... time to port!
Comment #8
dcam CreditAttribution: dcam commentedBackported #3 to D7.
Comment #9
dcam CreditAttribution: dcam commented#8: 1797272-8-t-filter.patch queued for re-testing.
Comment #10
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #11
izus CreditAttribution: izus commented#8: 1797272-8-t-filter.patch queued for re-testing.
Comment #13
dcam CreditAttribution: dcam commentedRerolled #8.
Comment #14
izus CreditAttribution: izus commentedHi,
the patch looks good for me
Thanks
Comment #15
jhodgdonThanks all! Committed to 7.x -- another one closed. :)