Part of meta #500866: [META] remove t() from assert message

CommentFileSizeAuthor
#13 1797272-13-t-filter.patch74 KBdcam
#8 1797272-8-t-filter.patch74.03 KBdcam
#3 1797272-3-t-filter.patch76.83 KBLars Toomre
#1 filter-1797272-1.patch65 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: xjm » Unassigned
Status: Active » Needs review
FileSize
filter-1797272-1.patch65 KB

Bigger. No format_string().

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: Remove t() from asserts messages in tests for the field module » Remove t() from asserts messages in tests for the filter module
Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
FileSize
1797272-3-t-filter.patch76.83 KB

This patch takes the patch from #1 and adds coveragefor missing coverage. This now has 212 changes across 8 Test files. According to my local install, there are no other t() changes needed for this module.

Let's see what the bot thinks of all of these cumulative changes.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

I tested #3. I didn't find any more t()'s around Filter module test assert messages. The patch looks ok to me.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented

Thanks for the review @dcam!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Assigned: Unassigned » jhodgdon

Tum te tum...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 8.x-dev » 7.x-dev
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks! 212 changes committed to 8.x... time to port!

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Patch (to be ported) » Needs review
FileSize
1797272-8-t-filter.patch74.03 KB

Backported #3 to D7.

dcam’s picture

dcam CreditAttribution: dcam commented

#8: 1797272-8-t-filter.patch queued for re-testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Issue tags: +Novice

Tagging as Novice.

izus’s picture

izus CreditAttribution: izus commented
Issue tags: -Novice, -Needs backport to D7

#8: 1797272-8-t-filter.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs backport to D7

The last submitted patch, 1797272-8-t-filter.patch, failed testing.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs work » Needs review
FileSize
1797272-13-t-filter.patch74 KB

Rerolled #8.

izus’s picture

izus CreditAttribution: izus commented
Status: Needs review » Reviewed & tested by the community

Hi,
the patch looks good for me
Thanks

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks all! Committed to 7.x -- another one closed. :)

Automatically closed -- issue fixed for 2 weeks with no activity.