Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#20 | tour-1979004-20.patch | 1.03 KB | ParisLiakos |
#16 | tour-1979004-16.patch | 1.03 KB | tim.plunkett |
#7 | tour_test_controller-1979004-7.patch | 3.84 KB | plopesc |
#5 | tour_test_controller-1979004-5.patch | 3.83 KB | plopesc |
#3 | tour_test_controller-1979004-3.patch | 4.11 KB | plopesc |
Comments
Comment #1
plopescHello
Attaching patch that convert tour_test_1() and tour_test_2() #1979010: Convert tour_test_2() to a Controller to a Controller.
Regards
Comment #2
dawehnerThis looks basically perfect.
If we don't inject anything there is no need for a constructor.
Comment #3
plopescRe-rolling patch
Comment #5
plopescRe-rolling patch excluding .swp files
Sorry
Comment #6
dawehnerneeds indentation, sorry I should have spotted this the first time.
Comment #7
plopescNo worries
Re-rolled.
Comment #9
plopesc#7: tour_test_controller-1979004-7.patch queued for re-testing.
Comment #11
plopescI can't figure why tests are failing now. Diff between patch in #5 and #7 are only comment indentations.
Moreover, test fail comes from an unrelated project, I think.
Maybe the failing test is related to one of the last commits.
Regards.
Comment #12
dawehner#7: tour_test_controller-1979004-7.patch queued for re-testing.
Comment #13
plopescAfter problems with test bot, this patch is green :)
@dawehner: Could be marked as RTBC now?
Regards
Comment #14
dawehnerGreat!
Comment #15
alexpottCommitted and pushed 6df1d3a and pushed to 8.x. Thanks!
Comment #16
tim.plunkettThis is unnecessary and vaguely confusing. We should avoid doing this in the future.
Comment #17
ParisLiakos CreditAttribution: ParisLiakos commentedagreed
Comment #18
ParisLiakos CreditAttribution: ParisLiakos commentedoops
returns?
Comment #19
alexpottLet's fix the typo...
Comment #20
ParisLiakos CreditAttribution: ParisLiakos commentedsure quickly manually edited the patch
Comment #22
ParisLiakos CreditAttribution: ParisLiakos commented#20: tour-1979004-20.patch queued for re-testing.
Comment #23
ParisLiakos CreditAttribution: ParisLiakos commentedit was a random failure:P
i think i can rtbc it, if i just have fixed a typo right?:P
Comment #24
tim.plunkettAfter some talk with @msonnabaum and @Crell, we're just going to let these happen. It's of course rather silly for a test controller, but it is useful for real ones in case something ever needs to be injected.
Comment #25.0
(not verified) CreditAttribution: commentedAdded link to META task