Remove <hgroup> from Zen templates [#1959000]

It doesn't really harm anything to leave it, but <hgroup> is being removed from W3's HTML 5.0 CR.

http://lists.w3.org/Archives/Public/public-html-admin/2013Apr/0003.html

feynman [zen] (7.x-5.x) $ grep -rn 'hgroup' *
STARTERKIT/css/normalize.css:30:hgroup,
STARTERKIT/sass/_normalize.scss:31:hgroup,
templates/maintenance-page.tpl.php:50:      <hgroup id="name-and-slogan">
templates/maintenance-page.tpl.php:60:      </hgroup>
templates/page.tpl.php:20:      <hgroup class="header--name-and-slogan" id="name-and-slogan">
templates/page.tpl.php:30:      </hgroup>
templates/pane-header.tpl.php:21:  <hgroup class="header--name-and-slogan" id="name-and-slogan">
templates/pane-header.tpl.php:31:  </hgroup>

These three are inside minified files:

js/html5-respond.js:3...
zen-internals/css/styles-fixed.css:1...
zen-internals/css/styles.css:1...

Comments

Comment #1

echoz CreditAttribution: echoz commented 12 April 2013 at 02:00

Status:

Active

» Fixed

Thanks, rupl. I saw this coming shortly after I added it. Done in commit http://drupalcode.org/project/zen.git/commit/98cb1c7

Comment #2

26 April 2013 at 02:10

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #3

JohnAlbin

he/they/他

English

Taipei, Taiwan

CreditAttribution: JohnAlbin commented 5 July 2013 at 05:24

Status:

Closed (fixed)

» Needs work

The <h2> around the site slogan is no longer contained with an hgroup, which means its semantics have changed. I think we need to change the h2 to something else.

We used a plain div in 7.x-3.x: http://drupalcode.org/project/zen.git/blob/refs/heads/7.x-3.x:/templates...