Next and previous buttons should scroll to top on multipage forms [#1341996]

Clicking the Next or Previous buttons should probably scroll the page up to the top. At the moment, if you have one page of the multipage form thats quite long, and the next page is very short, when you click the next button to go from the long page to the short page, you then have to scroll up to be able to see any of the form elements on the short page, as they are all right at the top.

Comment	File	Size	Author
#20	field_group-multipage-scroll-to-top-1341996-pk-20.patch	941 bytes	prashant.kabade
#19	field_group-multipage-scroll-to-top-1341996-20_0.patch	689 bytes	prashant.kabade
#19	field_group-multipage-scroll-to-top-1341996-20_0.patch	689 bytes	prashant.kabade
#18	field_group-multipage-scroll-to-top-1341996-19.patch	699 bytes	Nitesh Sethia
#16	field_group-multipage-scroll-to-top-1341996-16.patch	713 bytes	Nitesh Sethia
#10	field_group-multipage-scroll-to-top-1341996-10.patch	867 bytes	jantoine
#7	field_group-multipage-scroll-to-top-1341996-7.patch	853 bytes	anniegreens
#6	field_group-multipage-scroll-to-top-1341996-6.patch	2.92 KB	anniegreens
#5	field_group-multipage-scroll-to-top-1341996-5.patch	3.02 KB	anniegreens
#1	1341996-multipage-scroll-to-top.patch	904 bytes	mrfelton

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mrfelton CreditAttribution: mrfelton commented 15 November 2011 at 08:36

Version:	7.x-2.x-dev	» 7.x-1.x-dev
Status:	Active	» Needs review

File	Size
1341996-multipage-scroll-to-top.patch	904 bytes

Comment #2

bryancasler CreditAttribution: bryancasler commented 26 November 2011 at 21:18

Status:

Needs review

» Reviewed & tested by the community

Simple enough patch. Works as expected, just had to clear cache. Thanks for solving this mrfelton!

Comment #3

nils.destoop CreditAttribution: nils.destoop commented 3 December 2011 at 21:10

Status:

Reviewed & tested by the community

» Fixed

Changed the patch a bit. $('#page') is a bit hardcoded on theme. And a page group is not always on top of the page.
The window now pops to the multipage wrapper

Comment #4

17 December 2011 at 21:10

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #5

anniegreens CreditAttribution: anniegreens commented 26 April 2013 at 17:44

File	Size
field_group-multipage-scroll-to-top-1341996-5.patch	3.02 KB

Patch rerolled from #1 with the addition of whitespace removal.

Comment #6

anniegreens CreditAttribution: anniegreens commented 26 April 2013 at 17:48

File	Size
field_group-multipage-scroll-to-top-1341996-6.patch	2.92 KB

Sorry. Environment specific pathing removed from patch.

Comment #7

anniegreens CreditAttribution: anniegreens commented 4 June 2013 at 21:13

File	Size
field_group-multipage-scroll-to-top-1341996-7.patch	853 bytes

Re-rolled for latest dev using #page for those who want it. I'm still not convinced that the multipage group wrapper is the best solution, as it cuts off the top portion of the page that may be relevant.

Comment #8

kyleoliveira CreditAttribution: kyleoliveira commented 15 August 2013 at 21:07

The patch in #7 seems to work for me on simplytest.me. Is this not working for anyone? If not, any reason not to commit this?

Comment #9

katannshaw CreditAttribution: katannshaw commented 14 October 2013 at 18:44

@kyleoliveira:

FYI: Patch #7 worked great for me too. The only issue I had was when I also installed the Field Group Ajaxified Multipage module. For some reason, when you select the "Ajaxify" checkbox for a multipage group, the Next and Previous buttons don't scroll to the top. But if I un-select that checkbox, it works fine.

I'm guessing that if anyone has an issue at this point, it probably has something to do with that module, not the Field Group module with this patch on its own. I've created an issue report for that module with this information here: https://drupal.org/node/2111709.

Comment #10

jantoine CreditAttribution: jantoine as a volunteer commented 1 August 2015 at 23:02

Issue summary:	View changes
Status:	Closed (fixed)	» Needs review

File	Size
field_group-multipage-scroll-to-top-1341996-10.patch	867 bytes

4 files were hidden/shown/deleted

File	Size
1341996-multipage-scroll-to-top.patch	904 bytes
field_group-multipage-scroll-to-top-1341996-5.patch	3.02 KB
field_group-multipage-scroll-to-top-1341996-6.patch	2.92 KB
field_group-multipage-scroll-to-top-1341996-7.patch	853 bytes

Reroll of patch from #7. It seems that the issue was never reopened and comment #7 never addressed.

Comment #11

1 August 2015 at 23:03

Status:

Needs review

» Needs work

The last submitted patch, 10: field_group-multipage-scroll-to-top-1341996-10.patch, failed testing.

Comment #12

Rob_Feature CreditAttribution: Rob_Feature commented 4 August 2016 at 13:32

I tried implementing the patch in #7 into version 7.x-1.5 and it fails....it looks like the .js never even fires. Maybe I'm missing something?

Comment #13

david.qdoscc CreditAttribution: david.qdoscc commented 9 August 2018 at 00:32

If the form is displaying in the administrative overlay, then then using #overlay-container rather than #page worked for me.

EDIT: but only in Edge browser - doh!

Comment #14

Nitesh Sethia CreditAttribution: Nitesh Sethia as a volunteer and at Syngenta commented 3 January 2019 at 16:23

Status:

Needs work

» Needs review

#10 seems to be working for 7.x-1.5 version of the field_group module. We should plan to add this to the code as this would resolve the issue of scroll.

Thanks,
Nitesh Sethia