Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently taxonomy use custom admin/structure/taxonomy/{vocabulary}/edit
path that does not allow use of add/edit names and have a test for that.
Other core parts uses admin/.../{entity_type}/manage/{id}
path
Proposed resolution
Change path for all vocabularies to admin/structure/taxonomy/manage/%taxonomy_vocabulary/edit
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#11 | 1978112-taxonomy-path-11.patch | 32.48 KB | andypost |
#6 | 1978112-taxonomy-path-6.patch | 32.02 KB | andypost |
#4 | interdiff.txt | 7.09 KB | andypost |
#4 | 1978112-taxonomy-path-4.patch | 32.53 KB | andypost |
#2 | interdiff.txt | 635 bytes | andypost |
Comments
Comment #1
andypostTrying to keep it simple
Comment #2
andypostmissed hunk
Comment #4
andypostFix the rest places
Comment #5
larowlanunrelated?
Apart from that looks good.
Comment #6
andypostMerged properly, this one from commit #1975150: Remove variable_get from mymodule_shortcut_admin_default_set in the shortcut.api.php
Comment #7
andypost#6: 1978112-taxonomy-path-6.patch queued for re-testing.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedconsistency++
but needs a reroll..otherwise looks good
Comment #9
andypostBetter to re-roll this patch after #1946456: Convert taxonomy_term_confirm_delete() and taxonomy_vocabulary_confirm_delete() to the new form interface
Comment #11
andypostOnce other one needs work let's normalize path
Comment #12
dawehnerAwesome! I went through the changes and every single line looked perfect!
Comment #13
andypostWith this one we can close #843162: Creating vocabularies with machine-names "List" or "Add" breaks links in taxonomy overview admin area. or backport to 7.x
Comment #14
webchickI was a bit alarmed to see a big hunk of validation logic removed with no replacement until I realized how totally effing janky said validation is and I'm really glad we don't need it anymore. ;)
Committed and pushed to 8.x. Thanks!
Wouldn't hurt to have a change notice for this, for modules whose documentation or whatnot might be pointing to the old URLs.
Comment #15
LittleCodingWrite a API change notification
Comment #16
LittleCodingSummary
The Drupal taxonomy admin path was converted to follow other core entity admin patterns with the addition of "manage" to the admin path.
Drupal 7
Drupal 8
Comment #17
LittleCodingA change record node has been created
http://drupal.org/node/1986784
Comment #18
larowlanChanges record looks good
Comment #19
star-szrThis is fixed now, reverting tags and title. Thanks @LittleCoding!
Comment #20.0
(not verified) CreditAttribution: commented#843162: Creating vocabularies with machine-names "List" or "Add" breaks links in taxonomy overview admin area.