Convert this page callback to a new-style Controller, using the instructions on WSCCI Conversion Guide.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
3.71 KB

There we go.

ParisLiakos’s picture

+++ b/core/modules/toolbar/toolbar.moduleundefined
@@ -59,20 +59,6 @@ function toolbar_theme($existing, $type, $theme, $path) {
-    'page callback' => 'toolbar_subtrees_jsonp',

i cant see this callback deleted.is it used elsewhere?

+++ b/core/modules/toolbar/toolbar.moduleundefined
@@ -130,7 +116,7 @@ function toolbar_element_info() {
 function _toolbar_subtrees_access($hash) {

any reason you kept this?:)

dawehner’s picture

FileSize
1.67 KB
4.46 KB

Thanks for the review!

I wanted to keep the patch as small as possible, just kidding ;)

ParisLiakos’s picture

haha, smaller patches, easier to review:P

+++ b/core/modules/toolbar/lib/Drupal/toolbar/Routing/ToolbarController.phpundefined
@@ -0,0 +1,30 @@
+  public function subtreesJSONP() {

nitpick time then: i am not 100% sure about the naming of this method.shouldn't it be sunbtreeJsonp :)

dawehner’s picture

FileSize
1.15 KB
4.46 KB

There we go.

ParisLiakos’s picture

Status: Needs review » Reviewed & tested by the community

looks great now, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a5e363a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.