Follow up for #1953404: Add config schema to field and instance config entities
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in link module.
Schema in place
Schema not in place
field.link.settings
field.link.instance_settings
field.link.value
field_widget.link_default.settings
Comment | File | Size | Author |
---|---|---|---|
#13 | 1983906-config-schema-link-13.patch | 992 bytes | vijaycs85 |
#13 | 1983906-diff-6-13.txt | 1.35 KB | vijaycs85 |
#13 | Screen Shot 2013-12-11 at 19.25.10.png | 56.65 KB | vijaycs85 |
#13 | Screen Shot 2013-12-11 at 19.25.00.png | 67.24 KB | vijaycs85 |
#11 | 1983906-provide-config-schema-in-lin-module-11.patch | 1.25 KB | sushantpaste |
Comments
Comment #1
vijaycs85Comment #2
aitiba CreditAttribution: aitiba commentedAfter reading all the link provided and taking a look to the similar issue, this is what I have. :-)
Comment #3
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #4
piyuesh23 CreditAttribution: piyuesh23 commentedMoved field_widget out of the schema. Attaching the updated patch.
Comment #6
piyuesh23 CreditAttribution: piyuesh23 commentedPatch rerolled. Attaching a fixed patch.
Comment #7
piyuesh23 CreditAttribution: piyuesh23 commentedComment #8
aitiba CreditAttribution: aitiba commentedWith the last commit of the 8.x branch and on this branch I make the "git apply *.patch" and I dont get any errors. I dont know if this information is that is needed to review the issue or I need to be sure that on drupal screens go well too? If I need to be sure of this, ¿how can I make this on this case?
Comment #9
piyuesh23 CreditAttribution: piyuesh23 commented@aitiba The best way to test this would be using config_inspector module(https://drupal.org/project/config_inspector).
For details on how to use it, checkout this link https://drupal.org/node/1910624#comment-7088154.
Comment #10
sushantpaste@piyuesh23 Small modification in patch will be
S.
Comment #11
sushantpasteHere is the updated patch.
S.
Comment #12
aspilicious CreditAttribution: aspilicious commentedThis one needs work, sequence needs a '-' when defining the sequence.
And newline needed on the end.
Comment #13
vijaycs85thanks for the review @aspilicious. Here is the updated one with inspector screenshot...
Comment #14
aspilicious CreditAttribution: aspilicious commentedThis should be radio buttons, but it's understandable we can't determine that while processing the form...
Going to rtbc when it comes back green.
Comment #15
aspilicious CreditAttribution: aspilicious commentedIn the file patch we decided to got with the string for the radio, can't we do that here to?
Comment #16
vijaycs85The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.