Follow up for #1953404: Add config schema to field and instance config entities
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in number module.
Schema in place
Schema not yet in place
field.number_integer.settings
field.number_integer.instance_settings
field.number_integer.value
field.number_decimal.settings
field.number_decimal.instance_settings
field.number_decimal.value
field.number_float.settings
field.number_float.instance_settings
field.number_float.value
field_widget.number.settings
Comment | File | Size | Author |
---|---|---|---|
#8 | 1973450-config-schema-field-number-8.patch | 2.35 KB | yched |
#7 | 1973450-config-schema-field-number-7.patch | 2.63 KB | AjitS |
#6 | 1973450-config-schema-field-number-6.patch | 2.63 KB | AjitS |
#1 | 1973450-config-schema-field-number-1.patch | 2.77 KB | vijaycs85 |
#1 | field.field_.integer.form_.png | 34.2 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch with config_inspector forms..
Comment #2
vijaycs85Comment #3
swentel CreditAttribution: swentel commentedThe config schema for text does not capitalize the field module name. I'm not sure what the policy is, but let's make sure it's all the same :)
I'm trying to figure out where this points to ? Sorry if this is a stupid question :/
One other thing I've been wondering: 'DefaultNumberFormatter' class contains settings for the formatter ('Thousand marker' and 'Display prefix and suffix'). Is that something that needs to be in the config schema as well ?
Comment #4
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #5
Nitesh Sethia CreditAttribution: Nitesh Sethia commentedEverything working fine from my side.
Good to go....
Comment #6
AjitSRemoving widget as per #4.
Comment #7
AjitSPlease ignore the previous patch. Changed the module's name to lower case as per #3. Though I'm not sure about the 'DefaultNumberFormatter'.
Comment #8
yched CreditAttribution: yched commentedI just removed the user_register_form instance setting, it's a thing from the past now that form "form modes" are in.
Other than that, looks good, thanks !
Comment #10
yched CreditAttribution: yched commented#8: 1973450-config-schema-field-number-8.patch queued for re-testing.
Comment #11
yched CreditAttribution: yched commentedComment #12
yched CreditAttribution: yched commentedNote : opened #2049485: Remove traces of the 'user_register_form' field setting to remove 'user_register_form' from the existing config entries and config schemas
Comment #13
alexpottCommitted fc7cd79 and pushed to 8.x. Thanks!