Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Convert this page callback to a new-style Form object, using the instructions on http://drupal.org/node/1800686
Comment | File | Size | Author |
---|---|---|---|
#26 | user-1984610-26.patch | 10.11 KB | tim.plunkett |
#20 | drupal-1984610-20.patch | 10.52 KB | dawehner |
#20 | interdiff.txt | 5.74 KB | dawehner |
#16 | 1984610-user_pass_conversion-16.patch | 7.43 KB | Albert Volkman |
#15 | 1984610-user_pass_conversion-15.patch | 0 bytes | Albert Volkman |
Comments
Comment #1
Albert Volkman CreditAttribution: Albert Volkman commentedTagging
Comment #2
Albert Volkman CreditAttribution: Albert Volkman commentedThis is my first conversion, please be gentle :) I haven't converted the validate or submit functions yet.
Comment #3
Albert Volkman CreditAttribution: Albert Volkman commentedComment #5
dawehnerThanks for helping on all that conversion issues.
The current standard for @file is "Contains \...". just have a look at http://drupal.org/node/1354 for general informationl.
he, this controller is another controller :) Just extend no class by default. This works as well.
all that nitpicking is just to make it as perfect as possible. ... there should be an empty line after the first {
If you have nothing injected into the class, there is no reason to put that code here.
This method should be documented. In general: It's really great that you can just get the request object very easy here.
empty spaces.
Just wondering whether it makes more sense in a general UserController.
Feel free to ping me on IRC if you need help with fixing this failures.
Comment #6
Albert Volkman CreditAttribution: Albert Volkman commentedSecond try.
Comment #8
Albert Volkman CreditAttribution: Albert Volkman commentedErm, let's try that again.
Comment #10
dawehnerThis looks great so far, beside of the failing tests ^^
If you don't implement the ControllerInterface you also don't need the create method.
We use the full namespace on documentation.
Comment #11
Albert Volkman CreditAttribution: Albert Volkman commentedSince this is returning a form, I think I was approaching this incorrectly. Consider this take 2 :)
Comment #13
Albert Volkman CreditAttribution: Albert Volkman commentedAdded the Request object \Drupal::request(). Although, I'm assuming that's a hard dependency which shouldn't be added that way.
Comment #15
Albert Volkman CreditAttribution: Albert Volkman commentedRe-roll.
Comment #16
Albert Volkman CreditAttribution: Albert Volkman commentedArgh.
Comment #18
dawehnerYou could implement {@inheritdoc} ... and nothing else, because this is partially incorrect.
Have you tried to inject the request into the form?
{@inheritdoc}
What about injecting the user storage controller as well?
Comment #19
dawehnerAssigning to myself to inject the request into the form controller method.
Comment #20
dawehnerI think the proper way would be to use the controller resolver to pass in values instead of using custom reflection code.
Sadly this requires some hacks, but maybe we could get this fixed by extend our controller resolver.
Comment #21
ParisLiakos CreditAttribution: ParisLiakos commentedi cant believe how this forgotten piece havent bite us yet?
Besides the hacks, that i am not sure i can think of a better alternative, this should maybe _entity_form like i said to dawehner in irc
Comment #23
dawehnerAdded an issue to remove ControllerInterface: #1998140: Remove backward compatible ControllerInterface
i cant believe how this forgotten piece havent bite us yet?There is a BC-Interface for that ...
Comment #24
dawehnerBranched of the other part of my changes to #1998166: Use the controller resolver to inject parameters into HtmlFormController
Comment #25
ParisLiakos CreditAttribution: ParisLiakos commentedah..now i found out that crell kept a bc interface, so no conversions break during that
postponing this issue per #24
Comment #26
tim.plunkettWas too out of date for an interdiff.
Comment #27
dawehnerPerfect!
Comment #28
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!