Rename ViewsDataCache to ViewsData [#1989806]

It makes sense to rename the ViewsDataCache class to just ViewsData, it manages the views data, and just happens to use the cache backend and manage the getting/setting. So it's not just a cache it IS views data objectified :)

Also based on #1962234: [Change notice] Move views_fetch_fields into an autoloadable class I think that issue should use a class ViewsDataHelper.

Comment	File	Size	Author
#4	1989806-4.patch	14.11 KB	damiankloip
#4
	vdc.ViewsDataCache-rename.patch	13.06 KB	damiankloip

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

8 May 2013 at 08:43

Status:	Needs review	» Needs work
Issue tags:	-VDC

The last submitted patch, vdc.ViewsDataCache-rename.patch, failed testing.

Comment #2

damiankloip CreditAttribution: damiankloip commented 8 May 2013 at 08:45

Status:

Needs work

» Needs review

vdc.ViewsDataCache-rename.patch queued for re-testing.

Comment #3

8 May 2013 at 08:48

Status:	Needs review	» Needs work
Issue tags:		+VDC

The last submitted patch, vdc.ViewsDataCache-rename.patch, failed testing.

Comment #4

damiankloip CreditAttribution: damiankloip commented 8 May 2013 at 09:33

Status:

Needs work

» Needs review

File	Size
1989806-4.patch	14.11 KB

Sorry, didn't include the actual changes to ViewsDataCache in the patch!!!

Comment #5

dawehner

German

CreditAttribution: dawehner commented 16 May 2013 at 09:05

Status:

Needs review

» Reviewed & tested by the community

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewsDataTest.phpundefined
@@ -8,7 +8,7 @@
-use Drupal\views\ViewsDataCache;
+use Drupal\views\ViewsData;

Just to be sure similar systems in core are named the following: ThemeRegistry, SchemaCache, ModuleInfo, AliasWhitelist. To sum it up, it would be more consistent to rename it.

+++ b/core/modules/views/lib/Drupal/views/Tests/ViewsDataTest.phpundefined
@@ -40,7 +40,7 @@ class ViewsDataTest extends ViewUnitTestBase {
-      'name' => 'Table Data',
+      'name' => 'Views data',

Yeah, this always confused me.