Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
Also follow-up for #1872870: Implement a RoleListController and RoleFormController
Roles now a Config Entity with form and list controllers, so we need to get rid of hook_menu() here
-Also add RoleAccessController because delete has special check for system roles
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide
Comment | File | Size | Author |
---|---|---|---|
#12 | 1992428-drop_leftover_code.patch | 744 bytes | andypost |
#9 | interdiff.txt | 1.22 KB | andypost |
#9 | 1992428-roles-9.patch | 8.89 KB | andypost |
#6 | interdiff.txt | 3.38 KB | andypost |
#6 | 1992428-roles-6.patch | 8.91 KB | andypost |
Comments
Comment #1
andypostRole delete form conversion happens in #1946466: Convert all confirm_form() in user.module and user.pages.inc to the new form interface and convert route
Comment #2
andypostSuppose Delete form should be included in the patch
Comment #4
andypostreverted back unneeded changes
Comment #5
dawehnershould be $userRole or just $role?
It still feels kind of wrong to not document new parameters ...
... actually for the role entity type :)
Comment #6
andypostFix #5 and add changes from #1872870-46: Implement a RoleListController and RoleFormController (suppose better to fix this as follow-up, not here)
Comment #7
dawehnerOh drupal, please don't but in german words :(
Comment #8
tim.plunkettThis should typehint with \Drupal\user\RoleInterface
Otherwise it's perfect
Comment #9
andypostnice catch!
Comment #10
dawehnerPerfect!
Comment #11
alexpottCommitted 3282c15 and pushed to 8.x. Thanks!
Comment #12
andypostHere's a follow-up patch to cleanup left functions that obsolete
Comment #13
dawehnerThis code is not used anymore, checked via storm
Comment #14
alexpottYay for less code!
Committed ff0f94d and pushed to 8.x. Thanks!
Comment #15.0
(not verified) CreditAttribution: commentedUpdated issue summary.