Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As reported by xjm, the readmore link is not rendered anymore.
Comment | File | Size | Author |
---|---|---|---|
#14 | drupal-1970136-test.patch | 3.56 KB | olli |
#14 | drupal-1970136-14.patch | 4.91 KB | olli |
#14 | interdiff.txt | 2.67 KB | olli |
#12 | drupal-1970136-12.patch | 5.91 KB | dawehner |
#1 | drupal-1970136-1.patch | 4.5 KB | dawehner |
Comments
Comment #1
dawehnerLet's see whether the tests are working.
Comment #3
oresh CreditAttribution: oresh commented#1: drupal-1970136-1.patch queued for re-testing.
Comment #4
oresh CreditAttribution: oresh commentedBefore applying the patch the 'More link' in pager section:
Was set to Yes, but no link on the bottom of the view did not appear.
After applying the patch if showed me the link with correct text and link.
The "Display 'more' link only if there is more content" also works correctly. When enabled, and displaying 1 item on a page, i get it everywhere except the last page (as intended).
Doesn't get duplicated, markup is ok. So RTBC.
Thaks.
Comment #6
dawehnerForgot to add the config file.
PHP is really odd:
This html is read by simplexml into:
Comment #7
joelpittet#1 seems to fix the problem though I am not about the testbot failure, nor the intention behind converting some of the tests to private test functions...
Comment #8
thedavidmeister CreditAttribution: thedavidmeister commentedthe testbot failed because of a fatal error in a test introduced by the patch.
Comment #9
dawehner#1: drupal-1970136-1.patch queued for re-testing.
Comment #11
joelpittet@dawehner #6 references you are missing a yml file for 'test_display_more' and left and not sure if the test is fully finished with the private function changes I think were done for testing?
Comment #12
dawehnerRight I forgot to add the file, though I have no idea why this xpath doesn't return the actual link title.
Maybe someone can help.
Comment #14
olli CreditAttribution: olli commentedThat xpath looks good to me, but there is some spaces from views-more.tpl.php. Added trim().
Comment #15
olli CreditAttribution: olli commentedComment #17
olli CreditAttribution: olli commented#14: drupal-1970136-14.patch queued for re-testing.
Comment #18
joelpittetGreat work guys!
Comment #19
alexpottCommitted 91e164e and pushed to 8.x. Thanks!