Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#2 1987724-image-style-list-controller-2.patch4.11 KBkim.pepper
#2 interdiff.txt495 byteskim.pepper
#1 1987724-image-style-list-controller-1.patch4.15 KBkim.pepper
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Status: Active » Needs review
FileSize
1987724-image-style-list-controller-1.patch4.15 KB

Initial attempt.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
FileSize
interdiff.txt495 bytes
1987724-image-style-list-controller-2.patch4.11 KB

Shouldn't put an route on MENU_DEFAULT_LOCAL_TASK

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs review » Needs work

This looks great, thanks! just one small thing

+++ b/core/modules/image/image.routing.ymlundefined
--- /dev/null
+++ b/core/modules/image/lib/Drupal/image/Routing/ImageStyleController.phpundefined

+++ b/core/modules/image/lib/Drupal/image/Routing/ImageStyleController.phpundefined
@@ -0,0 +1,63 @@
+ * Contains \Drupal\image\Routing\ImageStyleController.

the folder should be Controller not Routing, aggregator and views ui got this wrong

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Closed (duplicate)

Duplicates #1809376: Use EntityListController for image styles