block $title_suffix is output after content [#1990530]

In block.tpl.php, the code:

  <?php print $content_processed; ?>

  <?php print render($title_suffix); ?>

is incorrect. They should be in the opposite order.

Comment	File	Size	Author
#3	1990530-block-tpl-fix-title-suffix.diff	462 bytes	znerol

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aliyakhan CreditAttribution: aliyakhan commented 13 May 2013 at 07:15

print render($title_suffix); This is closing div for the titles added by module to wrap the content. Did you face any issues regarding same?

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 13 May 2013 at 15:23

This is closing div

No, it's not.

According to the documentation in modules/block/block.tpl.php,

 * - $title_prefix (array): An array containing additional output populated by
 *   modules, intended to be displayed in front of the main title tag that
 *   appears in the template.
 * - $title_suffix (array): An array containing additional output populated by
 *   modules, intended to be displayed after the main title tag that appears in
 *   the template.

And the actual code there is:

  <?php print render($title_prefix); ?>
<?php if ($block->subject): ?>
  <h2<?php print $title_attributes; ?>><?php print $block->subject ?></h2>
<?php endif;?>
  <?php print render($title_suffix); ?>

  <div class="content"<?php print $content_attributes; ?>>
    <?php print $content ?>
  </div>

The suffix is meant to come right after the title, not after the content of the block.

Yes, I did have trouble with this, in a theme that set $title_suffix. It came out in the wrong place.

Comment #3

znerol CreditAttribution: znerol commented 30 May 2013 at 11:50

Status:

Active

» Needs review

File	Size
1990530-block-tpl-fix-title-suffix.diff	462 bytes

I agree, those two lines need to be swapped. Patch attached.

Comment #4

Jeff Burnz CreditAttribution: Jeff Burnz commented 5 December 2013 at 23:13

Version:	7.x-3.1	» 7.x-3.x-dev
Category:	Bug report	» Feature request
Issue summary:	View changes
Status:	Needs review	» Active

Somehow I totally overlooked this issue and patches.

Technically no change is needed. The only thing output by suffix (in Drupal core) is contextual links. I personally don't know of another module that uses this variable, so it's safe where they are. Really this is a feature request, there is no hard technical reason why I have to follow the documentation, and frankly I consider it to be rather overstating how we can or should use this variable. Its just not up to Core to tell me where to output contextual links, that is a theming decision.

If someone can show me a bug I'm all ears, otherwise I would prefer to leave this alone, mainly because there are so many existing AT installations and someone might have used this variable in their site (custom module etc), so could be a little dangerous to move it at this stage.