Drush adds d.o-style .info information for my private modules, causing Drupal to then check Drupal.org for updates to them.

Not sure how best to proceed. Checking for update info on d.o for each module seems excessive. Possibly only do .info rewriting for modules that have default (d.o) git repos?

CommentFileSizeAuthor
#5 no-info-private-repos-1881378-05.patch696 bytesjhedstrom
#2 drush-make-1881378-02.patch871 bytesjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented

Only rewriting for d.o. seems like the way to go.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Version: 7.x-5.8 » 8.x-6.x-dev
Status: Active » Needs review
FileSize
drush-make-1881378-02.patch871 bytes

Patch attached.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Needs review » Active

Oops, #2 is for a different issue (#1881380: .info rewriting broken for modules without a release).

dkingofpa’s picture

dkingofpa CreditAttribution: dkingofpa commented

It also causes git status and git diff to show changes in private repos when it's only the .info rewriting. It's a constant nuisance.

I was previously coming at this from the 7.x-5.x-dev version on #1890234: Do not override properties in .info files.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Active » Needs review
FileSize
no-info-private-repos-1881378-05.patch696 bytes

This should do the trick.

lotyrin’s picture

lotyrin CreditAttribution: lotyrin commented
Status: Needs review » Reviewed & tested by the community

Yep. That seems adequate.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Assigned: Unassigned » jhedstrom
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom commented
Status: Reviewed & tested by the community » Fixed

This was actually committed back in January (764ab31d).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jdillick’s picture

jdillick CreditAttribution: jdillick commented

Does anyone think the patch from #5 might break automated build processes for peeps who rely on drush make *to* put the versions in their custom modules? Any particular reason this couldn't bale on an argument --no-gitinfofile?

This is dissappointing. A behavior change such as this, which break version based dependencies, seems inappropriate, especially at version 5.9.

jdillick’s picture

jdillick CreditAttribution: jdillick commented
Status: Closed (fixed) » Needs review
greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
Status: Needs review » Closed (won't fix)
Issue tags: +Needs migration

This issue was marked closed (won't fix) because Drush has moved to Github.

If desired, you may copy this bug to our Github project and then post a link here to the new issue. Please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.