Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Main menu is broken on smaller screens in RTL and styles in general are not equivalent to the LTR styles.
Working on a patch.
Comment | File | Size | Author |
---|---|---|---|
#11 | bartik_menu_tabs_rtl-1994192-11.patch | 4.14 KB | mjohnq3 |
#7 | bartik_menu_tabs_rtl-1994192-7.patch | 2.59 KB | tsi |
#6 | bartik_menu_tabs_rtl-1994192-6.patch | 2.6 KB | mjohnq3 |
#6 | interdiff.txt | 672 bytes | mjohnq3 |
#4 | bartik_menu_tabs_rtl-1994192-4.patch | 3.62 KB | tsi |
Comments
Comment #1
tsi CreditAttribution: tsi commentedComment #2
Gábor HojtsyComment #3
mjohnq3 CreditAttribution: mjohnq3 commentedThis looks good except for one minor problem - no left padding on the main menu tabs. See attached screenshot and interdiff.txt.
Comment #4
tsi CreditAttribution: tsi commentedThe padding there should be (according to the LTR styles)
padding: 0.7em 0.8em;
and apply only under themin-width: 901px
media query, this means we add a line to the RTL styles which looks the same as the LTR equivalent only for cascading reasons (patch attached). not perfect but maybe we have no choice.Comment #6
mjohnq3 CreditAttribution: mjohnq3 commentedI'll take another crack at this. The affected css is now mobile-first.
Comment #7
tsi CreditAttribution: tsi commentedThere's a tab that snuck in there.
Besides that, seems like #6 does the same as #4 only that it is formatted better (mine got messed up by git) so it is fine by me.
This one removes the tab.
Comment #8
thamasTested the last patch, it works well.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to 8.x. but I'd like us to clean up the comments. They are not very consistent.
Comment #10
xjmTo clarify @Dries' comment, the new hyphen-header things have more hyphens and the case is not consistent.
Comment #11
mjohnq3 CreditAttribution: mjohnq3 commentedThe hyphen-header thingies are now all title case and start at column #24. The ending "/" all end at column #62.
Comment #13
Gábor Hojtsy#11: bartik_menu_tabs_rtl-1994192-11.patch queued for re-testing.
Comment #14
Gábor HojtsyLooks fine!
Comment #15
alexpottCommitted b3b93ac and pushed to 8.x. Thanks!