Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Patch attached fixes some bugs in strings.
| Comment | File | Size | Author |
|---|---|---|---|
| html5_tools_Translatable+string+bugfixes.patch | 2.12 KB | hass |
Comments
Comment #1
ericduran CreditAttribution: ericduran commentedComment #2
ericduran CreditAttribution: ericduran commentedThanks fix with proper commit attribution.
Comment #3
hass CreditAttribution: hass commentedhttp://drupalcode.org/project/html5_tools.git/commit/21e9517 looks like an incomplete commit. You missed to fix the string starting with "Adds the X-UA-Compatible:" and the leading spaces.
Comment #4
ericduran CreditAttribution: ericduran commentedNope I did that was on purpose.
I don't see why the link would need to be translated.
Comment #5
hass CreditAttribution: hass commentedThis is a context sensitive bug. Please read developer guides. We are not allowed to use l() to build links inside translatable strings. Translators mudt understand the full sentence. It's not up to the maintainer to decide if something will be translated or not.
Comment #6
hass CreditAttribution: hass commentedHere is the documentation http://drupal.org/node/322774
Comment #7
ericduran CreditAttribution: ericduran commentedHa, I guess that makes sense.
Comment #8
bleen CreditAttribution: bleen commentedlooks like ericduran fixed this but never marked the issue...
Comment #9
hass CreditAttribution: hass commentedI'm not aware of this. He has not commited the remaining parts or what was the commit?
Comment #10
hass CreditAttribution: hass commentedIt's not committed!
Comment #11
bleen CreditAttribution: bleen commentedWeird ... I couldof sworn ... hmph... clearly I was drunk at the time.
Anyway... now its committed: http://drupalcode.org/project/html5_tools.git/commit/3fe6dda
Comment #12
hass CreditAttribution: hass commentedThx :-)