Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/aggregator/tests/aggregator_test.module
CommentFileSizeAuthor
#3 1999338-3-aggregator_test-SERVER-variable-replacement.patch1006 byteschertzog
#1 1999338-1-aggregator_test-SERVER-variable-replacement.patch1.13 KBchertzog
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Active » Needs review
FileSize
1999338-1-aggregator_test-SERVER-variable-replacement.patch1.13 KB

First shot.

Status: Needs review » Needs work

The last submitted patch, 1999338-1-aggregator_test-SERVER-variable-replacement.patch, failed testing.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Needs work » Needs review
FileSize
1999338-3-aggregator_test-SERVER-variable-replacement.patch1006 bytes

stupid syntax.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Assigned: Unassigned » chertzog
pbuyle’s picture

pbuyle CreditAttribution: pbuyle commented
Status: Needs review » Reviewed & tested by the community

Not using Drupal::request()->server->has('...') as replacement of the original isset($_SERVER['...']) is ok here. Without the consumed server value, the returned value of strtotime() and stripslashes will be NULL and "". Since $if_modified_since and $if_none_match are compared to expected values using ==, the behavior should be the same.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.