Use Symfony Request for file module [#1999370]

Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

core/modules/file/file.install
core/modules/file/file.module

Comment	File	Size	Author
#7	1999370-file-request-5.patch	1.72 KB	kim.pepper
#7
#7	interdiff.txt	2.23 KB	kim.pepper
#3	1999370_3-replace_raw-variables-file.patch	2.79 KB	chertzog
#3
#1	1999370_1-replace_raw-variables-file.patch	2.79 KB	chertzog
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chertzog

he/him

English

Harrisburg, PA, USA

CreditAttribution: chertzog commented 23 May 2013 at 05:09

Assigned:	Unassigned	» chertzog
Status:	Active	» Needs review

File	Size
1999370_1-replace_raw-variables-file.patch	2.79 KB

Comment #2

23 May 2013 at 05:13

Status:

Needs review

» Needs work

The last submitted patch, 1999370_1-replace_raw-variables-file.patch, failed testing.

Comment #3

chertzog

he/him

English

Harrisburg, PA, USA

CreditAttribution: chertzog commented 23 May 2013 at 05:21

Status:

Needs work

» Needs review

File	Size
1999370_3-replace_raw-variables-file.patch	2.79 KB

missed a semicolon.

Comment #4

rbayliss CreditAttribution: rbayliss commented 23 May 2013 at 05:58

+++ b/core/modules/file/file.moduleundefined
@@ -738,8 +738,8 @@ function file_cron() {
-  if (empty($_POST['form_build_id']) || $form_build_id != $_POST['form_build_id']) {
+  $request = Drupal::request()->request->get('form_build_id');
+  if (empty($request) || $form_build_id != $request) {

$request is kind of confusing. How about $request_form_build_id?