Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
On line 180 in tour.js we have the following line:
if ((itemId || itemClass) && $document.find('#' + itemId + ', .' + itemClass).length === 0) {
If "itemClass" or "itemId" are not provided we end up with something like "#, .foo" or "#foo, ." we need to check these individually.
Comment | File | Size | Author |
---|---|---|---|
#7 | 1995152-7-broken-selector.patch | 642 bytes | nick_schuch |
#4 | 1995152-4-broken-selector.interdiff.txt | 642 bytes | nick_schuch |
#4 | 1995152-4-broken-selector.patch | 827 bytes | nick_schuch |
#2 | 1995152-1-broken-selector.patch | 866 bytes | nick_schuch |
Comments
Comment #1
nod_tag
Comment #2
nick_schuch CreditAttribution: nick_schuch commentedI have refreshed the logic to look for the itemId and/or itemClass first before checking the page.
Comment #3
nod_I don't think we need the first line.
Comment #4
nick_schuch CreditAttribution: nick_schuch commentedRight you are! Cheers!
Comment #5
nod_Comment #6
alexpottCommitted 5a60cba and pushed to 8.x. Thanks!
Comment #7
nick_schuch CreditAttribution: nick_schuch commentedThis broke modal's. I must have had cache js while testing. :(
Comment #8
nod_ok the condition looks better like that.
Comment #9
nod_tag for sprint :)
Comment #10
nick_schuch CreditAttribution: nick_schuch commentedSome steps to test #7:
1) Apply the patch in #7.
2) Apply the forum tour patch: https://drupal.org/node/1926296#comment-7445882
3) Enable the forum module.
4) Go to the "Add container" form for forum.
5) Start the tour. The first tip you should see if the a modal tip.
Comment #11
larowlanLets get this in
Comment #12
alexpottCommitted ae1116d and pushed to 8.x. Thanks!
Comment #13.0
(not verified) CreditAttribution: commentedUpdate description.