On line 180 in tour.js we have the following line:

if ((itemId || itemClass) && $document.find('#' + itemId + ', .' + itemClass).length === 0) {

If "itemClass" or "itemId" are not provided we end up with something like "#, .foo" or "#foo, ." we need to check these individually.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Issue tags: +JavaScript

tag

nick_schuch’s picture

Status: Active » Needs review
FileSize
866 bytes

I have refreshed the logic to look for the itemId and/or itemClass first before checking the page.

nod_’s picture

I don't think we need the first line.

nick_schuch’s picture

Right you are! Cheers!

nod_’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5a60cba and pushed to 8.x. Thanks!

nick_schuch’s picture

Status: Fixed » Needs review
FileSize
642 bytes

This broke modal's. I must have had cache js while testing. :(

nod_’s picture

ok the condition looks better like that.

nod_’s picture

tag for sprint :)

nick_schuch’s picture

Some steps to test #7:

1) Apply the patch in #7.
2) Apply the forum tour patch: https://drupal.org/node/1926296#comment-7445882
3) Enable the forum module.
4) Go to the "Add container" form for forum.
5) Start the tour. The first tip you should see if the a modal tip.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Lets get this in

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ae1116d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Update description.