Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
#1984610: Convert user_pass to a new-style Form object showed us that you can't inject the request object into the form method.
Instead of manually using some reflection we can rely on the controller resolver which does all this fancy logic.
Comment | File | Size | Author |
---|---|---|---|
#11 | drupal-1998166-11.patch | 6.63 KB | dawehner |
#6 | drupal-1998166-6.patch | 6.51 KB | dawehner |
#6 | interdiff.txt | 806 bytes | dawehner |
#1 | drupal-1998166-1.patch | 6.63 KB | dawehner |
Comments
Comment #1
dawehnerComment #2
ParisLiakos CreditAttribution: ParisLiakos commentedtagging
Comment #3
Crell CreditAttribution: Crell commentedI'm not sure I'd even bother removing form and form_state at the end. It doesn't hurt anything, does it?.
Otherwise, I like this cleanup.
Comment #4
dawehnerI hope noone has the idea to put 'form' into the request attributes manually.
Comment #5
Crell CreditAttribution: Crell commentedMm, true, that would cause a problem. Effectively then we just blacklist those two variable names. Are we OK doing that?
Comment #6
dawehnerLet's agree on that.
Comment #8
dawehnerLet us go with #1 because it is safer.
Comment #9
tim.plunkett#1 is RTBC
Comment #11
dawehnerJust reupload the one in #1
Comment #12
tim.plunkettThis removes a HUGE DrupalWTF in that half of controllers can get Request $request, but not forms.
Comment #13
tim.plunkett#11: drupal-1998166-11.patch queued for re-testing.
Comment #14
alexpottCommitted 040ff57 and pushed to 8.x. Thanks!