Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal-rename-summary-basics-2002988-5.patch | 2.72 KB | tvlooy |
#3 | drupal-rename-summary-basics-2002988-3.patch | 2.72 KB | kenianbei |
Comments
Comment #1
SpartyDan CreditAttribution: SpartyDan commentedPart of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment #2
kenianbei CreditAttribution: kenianbei commentedComment #3
kenianbei CreditAttribution: kenianbei commentedFirst patch for drupal core, whoop!
Comment #4
elvis2 CreditAttribution: elvis2 commented@kenianbei, thanks for contributing. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
You can see an example patch here: http://drupal.org/node/2001672
Comment #5
tvlooy CreditAttribution: tvlooy commentedAdded the access modifier.
Comment #6
elvis2 CreditAttribution: elvis2 commentedLooks good.
Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696
Comment #7
alexpottCommitted 4547223 and pushed to 8.x. Thanks!