Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | core-rename_get_field_value_TO_getFieldValue-2002914-9.patch | 1.15 KB | seantwalsh |
#2 | VDC-Rename_get_field_value-2002914-2.patch | 1.14 KB | seantwalsh |
Comments
Comment #1
seantwalshWorking on this as part of the Portland2013 getting involved with core sprint.
Comment #2
seantwalshReplaced 2 instances of get_field_value with getFieldValue.
Comment #4
connorwk CreditAttribution: connorwk commented#2: VDC-Rename_get_field_value-2002914-2.patch queued for re-testing.
Comment #6
oenie CreditAttribution: oenie commented#2: VDC-Rename_get_field_value-2002914-2.patch queued for re-testing.
Comment #7
oenie CreditAttribution: oenie commentedPatch send for retest, error was due to commit that has since been reverted.
Add protected access modifier in front of the function to adher to the new OOP standards.
Comment #8
seantwalshWorking on adding the access modifier.
Comment #9
seantwalshAdded protected access. Thanks oenie!
Comment #10
oenie CreditAttribution: oenie commentedAgain, patch looks good to me now ! If the patch passed testbot, it's RTBC for me !
Comment #11
oenie CreditAttribution: oenie commentedComment #12
alexpottCommitted 4da6c73 and pushed to 8.x. Thanks!
Comment #14
hansfn CreditAttribution: hansfn commentedWhy exactly? The function getField (which returns the rendered fields) is public. In a module I maintain (Views Send) I need access to both the rendered and raw fields.
PS! I can open a new issue if that is preferred.
Comment #15
alexpott@hansfn - yep a new issue would be great