Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | views-core-value-submit-2003236-09.patch | 3.15 KB | SpartyDan |
#6 | views-valueSubmit-2003236-6.patch | 3.13 KB | zschmid |
#2 | drupal-rename-value-submit-2003236-2.patch | 3.1 KB | kenianbei |
Comments
Comment #1
kenianbei CreditAttribution: kenianbei commentedComment #2
kenianbei CreditAttribution: kenianbei commentedComment #4
SpartyDan CreditAttribution: SpartyDan commented@kenianbei - It looks like you should resubmit your patch.
The failure message was: Setup environment - The testbot client is probably malfunctioning.
Your patch looks good to me.
Comment #5
aspilicious CreditAttribution: aspilicious commentedshould be public function valueSubmit (in all cases)
Comment #6
zschmid CreditAttribution: zschmid commentedupdated patch
Comment #7
zschmid CreditAttribution: zschmid commentedComment #8
aspilicious CreditAttribution: aspilicious commentedLooking at this again, this should be protected :s. Srry!
The function is only used internally by filter plugins.
Comment #9
SpartyDan CreditAttribution: SpartyDan commentedfunctions changed to protected
Comment #10
aspilicious CreditAttribution: aspilicious commentedComment #11
alexpottCommitted c93be24 and pushed to 8.x. Thanks!