Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 views_rename_uses_tokens-2002938-8.patch741 bytesnathangervais
#2 views-rename_uses_tokens_function-2002938-2.patch734 bytesvuzzbox
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vuzzbox’s picture

vuzzbox CreditAttribution: vuzzbox commented
Assigned: Unassigned » vuzzbox

Working on this at 2013 DrupalCon "getting involved sprint." Wish me luck.

vuzzbox’s picture

vuzzbox CreditAttribution: vuzzbox commented
FileSize
views-rename_uses_tokens_function-2002938-2.patch734 bytes

renamed function uses_tokens to usesTokens

vuzzbox’s picture

vuzzbox CreditAttribution: vuzzbox commented
Status: Active » Needs review

Ready for review.

Status: Needs review » Needs work

The last submitted patch, views-rename_uses_tokens_function-2002938-2.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Strange seams like a random fail...
Can you please prepend the function with public "public function usesTokens".

Thnx!

vuzzbox’s picture

vuzzbox CreditAttribution: vuzzbox commented
Status: Needs work » Needs review

I think all tests would be failing randomly because of an issue in a block positioning test not related to this (or many other issues). that test is failing randomly, but a patch was posted to fix it. See this issue: http://drupal.org/node/1987952#comment-7454266

Once that is fixed, this should pass.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

yeah but you still need tyo prepend the function with "public".
Views has realy old code and adding the correct type is needed in this issue.

nathangervais’s picture

nathangervais CreditAttribution: nathangervais commented
Assigned: vuzzbox » nathangervais
Status: Needs work » Needs review
FileSize
views_rename_uses_tokens-2002938-8.patch741 bytes

Rerolled Patch with public modifier.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This function is not used at all. I have the feeling that this is just wrong.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Should we remove it?

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

Should we convert it for now and create a follow-up to decide if it should be removed.

vuzzbox’s picture

vuzzbox CreditAttribution: vuzzbox commented

I noticed this, too, no instances of this function being called.

Is it possible that it's being used by contrib modules? Is it possible to determine which contrib modules might be calling any given core function?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Let's not remove code for now, as there might be contrib modules requiring this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed ad6858d and pushed to 8.x. Thanks!

So can so do a scan of contrib to see if this is used...

Automatically closed -- issue fixed for 2 weeks with no activity.