Support from Acquia helps fund testing for Drupal Acquia logo

Comments

theladebug’s picture

Assigned: Unassigned » theladebug
theladebug’s picture

Status: Active » Needs review
FileSize
3.15 KB

Status: Needs review » Needs work

The last submitted patch, updated-function-name-2003282.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
theladebug’s picture

Status: Needs review » Needs work

The last submitted patch, rename-set-items-per-page-2003282.patch, failed testing.

theladebug’s picture

Status: Needs work » Needs review
FileSize
3.81 KB

changed function visibility to public

Status: Needs review » Needs work

The last submitted patch, rename-set-items-per-page-2003282-7.patch, failed testing.

sillygwailo’s picture

This issue is related to #2002920: Rename Views method get_items_per_page() to getItemsPerPage() and that issue should maybe get resolved before this one, where references to get_items_per_page() for this patch are changed to getItemsPerPage() (i.e. a manual merge conflict resolution might be necessary).

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
3.77 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, 2003282-rename-set_items_per_page.patch, failed testing.

drupee’s picture

Assigned: theladebug » drupee
Status: Needs work » Active
heddn’s picture

Status: Active » Needs review
FileSize
570 bytes
4.45 KB

Switched to public. Let's see if that makes the testbot happy.

drupee’s picture

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

There we go! No other instances left.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b69a5af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.