Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-rename_use_pager_to_usePager-2002948-6.patch5.46 KBJeroenT
#2 views.module-replace_use_pager-2002948-02.patch5.44 KBtoddtomlinson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Status: Active » Needs review
FileSize
views.module-replace_use_pager-2002948-02.patch5.44 KB

Patch created to rename use_pager. See attached.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views.module-replace_use_pager-2002948-02.patch, failed testing.

toddtomlinson’s picture

toddtomlinson CreditAttribution: toddtomlinson commented
Status: Needs work » Needs review

#2: views.module-replace_use_pager-2002948-02.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, views.module-replace_use_pager-2002948-02.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_use_pager_to_usePager-2002948-6.patch5.46 KB

rename views method use_pager to usePager().

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f013f08 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.