Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#12 | views-buildGroupForm-2002378-12.patch | 1.17 KB | shnark |
#12 | interdiff-9-12.txt | 1.18 KB | shnark |
#9 | views-buildGroupForm-2002378-9.patch | 1.55 KB | zschmid |
#7 | views.module-rename_group_build_form_2002378_4.patch | 767 bytes | watsonerror |
#4 | views.module-rename_group_build_form-2002378-03.patch | 1.13 KB | toddtomlinson |
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
toddtomlinson CreditAttribution: toddtomlinson commentedPatch applied that renames build_group_form.
Comment #3
toddtomlinson CreditAttribution: toddtomlinson commentedComment #4
toddtomlinson CreditAttribution: toddtomlinson commentedFixed the patch. Had included previous changes. Only lists build_group_form now.
Comment #5
oenie CreditAttribution: oenie commentedAdd protected access modifier in front of the function to adher to the new OOP standards.
Comment #6
watsonerror CreditAttribution: watsonerror commentedgot it
Comment #7
watsonerror CreditAttribution: watsonerror commentedfunction is now protected
Comment #8
oenie CreditAttribution: oenie commentedYou have to make sure there is one patch that contains all changes needed.
Your latest patch is only the latest change.
Try again, including all changes from the original patches.
Comment #9
zschmid CreditAttribution: zschmid commentedUpdated patch
Comment #11
zschmid CreditAttribution: zschmid commentedThe issue here is that the buildGroupForm namespace is already used at around line 419 of FilterPluginBase.php .
renaming the build_group_form method to buildGroupForm throws all sorts of errors. any suggestions on what we should rename this to, to avoid the conflict?
Comment #12
shnark CreditAttribution: shnark commentedi read the function and picked a more specific name.
Comment #13
dawehnerLooks wonderful. There are just these two instances.
Comment #14
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #15
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.