Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericthelast’s picture

I'm working on this issue now.

ericthelast’s picture

Assigned: Unassigned » ericthelast
ericthelast’s picture

Status: Active » Needs review
FileSize
3.47 KB

Updated all methods & docblocks references.

Status: Needs review » Needs work

The last submitted patch, views_rename_function-2003330-2.patch, failed testing.

heddn’s picture

Several tests are failing. Needs investigation.

ericthelast’s picture

Yeah, I've looked into it but honestly I'm at a loss. Not sure where to go from here.

heddn’s picture

If we can't figure it out by Thurs night, this would be a good topic for the st louis meetup.

chrisjlee’s picture

Looks like you need to find the class that it's inheriting. I have no clue either it's hard to tell from the patch.

heddn’s picture

Status: Needs work » Needs review
FileSize
3.42 KB
3.05 KB

Let's see if this works. I think the changes in #2 were a little too aggressive and also changed 'render_item'.

ericthelast’s picture

Nice catch Lucas! Thanks for looking into it.

Status: Needs review » Needs work

The last submitted patch, drupal-viewsRenameRenderItems-2003330-9.patch, failed testing.

heddn’s picture

Status: Needs work » Needs review
FileSize
3.46 KB
1.97 KB

Let's see if this patch will work.

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -112,7 +112,7 @@ function get_items($values) {
+   * inheriting from this does not implement a 'renderItem' method.

missing s in renderItems

dcam’s picture

Status: Needs review » Needs work

Setting status per #13.

heddn’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -112,7 +112,7 @@ function get_items($values) {
+   * inheriting from this does not implement a 'renderItem' method.

Are we sure this should be plural? The actual code calls return method_exists($this, 'render_item'); on line 120.

heddn’s picture

This patch addresses #13.

heddn’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 579780c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.