Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#16 | drupal-renameViews-render_items-2003330-16.patch | 3.47 KB | heddn |
#12 | interdiff.txt | 1.97 KB | heddn |
#12 | drupal-viewsRenameRenderItems-2003330-12.patch | 3.46 KB | heddn |
#9 | interdiff.txt | 3.05 KB | heddn |
#9 | drupal-viewsRenameRenderItems-2003330-9.patch | 3.42 KB | heddn |
Comments
Comment #1
ericthelast CreditAttribution: ericthelast commentedI'm working on this issue now.
Comment #2
ericthelast CreditAttribution: ericthelast commentedComment #3
ericthelast CreditAttribution: ericthelast commentedUpdated all methods & docblocks references.
Comment #5
heddnSeveral tests are failing. Needs investigation.
Comment #6
ericthelast CreditAttribution: ericthelast commentedYeah, I've looked into it but honestly I'm at a loss. Not sure where to go from here.
Comment #7
heddnIf we can't figure it out by Thurs night, this would be a good topic for the st louis meetup.
Comment #8
chrisjlee CreditAttribution: chrisjlee commentedLooks like you need to find the class that it's inheriting. I have no clue either it's hard to tell from the patch.
Comment #9
heddnLet's see if this works. I think the changes in #2 were a little too aggressive and also changed 'render_item'.
Comment #10
ericthelast CreditAttribution: ericthelast commentedNice catch Lucas! Thanks for looking into it.
Comment #12
heddnLet's see if this patch will work.
Comment #13
dawehnermissing s in renderItems
Comment #14
dcam CreditAttribution: dcam commentedSetting status per #13.
Comment #15
heddnAre we sure this should be plural? The actual code calls
return method_exists($this, 'render_item');
on line 120.Comment #16
heddnThis patch addresses #13.
Comment #17
heddnComment #18
dawehnerNice!
Comment #19
alexpottCommitted 579780c and pushed to 8.x. Thanks!