Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#3 | 2002420-check_access-2.patch | 3.32 KB | oenie |
#2 | 2002420-check_access-1.patch | 3.3 KB | oenie |
Comments
Comment #1
oenie CreditAttribution: oenie commentedComment #2
oenie CreditAttribution: oenie commentedThis tag covers two separate check_access functions
- 1 in views/lib/Drupal/views/Plugin/views/argument_validator/ArgumentValidatorPluginBase.php
- 1 in views/lib/Drupal/views/Plugin/views/argument_default/ArgumentDefaultPluginBase.php
Comment #3
oenie CreditAttribution: oenie commentedSame patch, but added the forgotten access modifier for both functions.
Comment #5
oenie CreditAttribution: oenie commented#3: 2002420-check_access-2.patch queued for re-testing.
Comment #6
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #7
alexpott@oenie it's a point of process not to rtbc your own patches.
Comment #8
oenie CreditAttribution: oenie commented@alexxpott: a bit too eager, hadn't even noticed that !
sorry :)
Comment #9
aspilicious CreditAttribution: aspilicious commented#3: 2002420-check_access-2.patch queued for re-testing.
Comment #10
dawehnerI can do that :)
Comment #11
alexpottCommitted fb03231 and pushed to 8.x. Thanks!